Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compute): update the resource description #544

Merged
merged 4 commits into from
Dec 5, 2023
Merged

chore(compute): update the resource description #544

merged 4 commits into from
Dec 5, 2023

Conversation

savijatv
Copy link

@savijatv savijatv commented Nov 30, 2023 •
edited
Loading

Change the test policy description to match the actual use case.

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

  • Yes, this sample will be (or already is) included on cloud.google.com
    Location(s):

  • No, this sample won't be included on cloud.google.com
    Reason:

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

Update the OS policy description in the sample
9cd171f 
Change the test policy description to match the actual use case.
@savijatv savijatv requested review from a team as code owners November 30, 2023 17:12
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Nov 30, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@savijatv
Copy link
Author

/assign msampathkumar

@msampathkumar msampathkumar changed the title docs(Compute): Update the OS policy description in the sample chore(compute): Update the OS policy description in the sample Nov 30, 2023
@msampathkumar
Copy link
Contributor

/gcbrun

@msampathkumar msampathkumar changed the title chore(compute): Update the OS policy description in the sample chore(compute): update the resource description Nov 30, 2023
@msampathkumar msampathkumar enabled auto-merge (squash) November 30, 2023 17:50
@msampathkumar
Copy link
Contributor

/gcbrun

msampathkumar
msampathkumar approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only descriptions update. No code changes.

@msampathkumar
Copy link
Contributor

/gcbrun

@msampathkumar msampathkumar added the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2023
@savijatv
Copy link
Author

savijatv commented Dec 5, 2023

/gcbrun

@msampathkumar msampathkumar merged commit b48aea8 into terraform-google-modules:main Dec 5, 2023
4 of 5 checks passed
@savijatv savijatv deleted the patch-3 branch December 5, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msampathkumar msampathkumar msampathkumar approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savijatv @msampathkumar